Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added user profile edit option #262

Closed
wants to merge 89 commits into from
Closed

Added user profile edit option #262

wants to merge 89 commits into from

Conversation

SnehaVeerakumar
Copy link

@SnehaVeerakumar SnehaVeerakumar commented Apr 16, 2021 •
edited
Loading

Describe the changes you've made

User can change their password and update their profile from "user" drop down in navigation bar.

Fixes: #194

##Working video
https://drive.google.com/file/d/1jWD6C4rjfXPN8mGnFF7JhL8w25DIc-g4/view?usp=sharing

##Project set up
python manage.py makemigrations
python manage.py migrate

Making migrations is necessary to migrate created models.

Type of change

User can now edit their details

Example how to mark a checkbox :-

  • My code follows the code style of this project.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

By deploying in localhost

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

##Screenshots
Screenshot (1034)
Screenshot (1035)
Screenshot (1036)
Screenshot (1037)

tanishq-arya and others added 20 commits March 28, 2021 12:36
@tanishq-arya
styled helpline, added meta tag to common
a000a6c
@tanishq-arya
changes to td a tags
9e8f794
@tanishq-arya
Merge branch 'master' of https://github.com/swapnilsparsh/Rescue into…
9b88c01 
… helpline
@tanishq-arya
Merge branch 'master' of https://github.com/swapnilsparsh/Rescue into…
9da9670 
… helpline
@tanishq-arya
fixed and styled login page
cfb8b5e
@tanishq-arya
Merge branch 'master' of https://github.com/swapnilsparsh/Rescue into…
a6fcc5b 
… helpline
@tanishq-arya
fixed login page
62e2678
added delete account feature
e8b1d52
@naman153
Adding Women Safety Numbers Statewise
7ed0288
@VaibhavSharma24
FAQ Page Added
1395677
@tanishq-arya
Merge branch 'master' of https://github.com/swapnilsparsh/Rescue into…
a702220 
… helpline
@tanishq-arya
fixed register mobile view
2172715
@SnehaVeerakumar
profile edit view
7eb1af8
@SnehaVeerakumar
adding link to profile update page
d6522bd
@SnehaVeerakumar
Update admin.py
65f82b8
@SnehaVeerakumar
User profile models
534314b
@SnehaVeerakumar
added profile edit page url
be4faa2
@SnehaVeerakumar
Update views.py
9bec7a5
@SnehaVeerakumar
Update settings.py
1173199
@SnehaVeerakumar
Update urls.py
2b1e265
@swapnilsparsh
Copy link
Owner

@SnehaVeerakumar If the email id is already registered and then user is changing its email then did it show that email is available or not ?

@khanfarhan10
Copy link

I think it's best to leave out the useremail unchanged.

@SnehaVeerakumar
Copy link
Author

Working demo :
https://1drv.ms/v/s!AhQCqna6zNwBjimSQPH1mWovWGcS?e=vGV8eB

@sakshikhachane
Copy link
Collaborator

@SnehaVeerakumar I will have a talk with Project Admin and will let you know.

@SnehaVeerakumar
Copy link
Author

@SnehaVeerakumar I will have a talk with Project Admin and will let you know.

Once you try running the program ! What if it works as it is working in my local machine

@swapnilsparsh
Copy link
Owner

@SnehaVeerakumar Can you tell me what problem are you facing?

@SnehaVeerakumar
Copy link
Author

@SnehaVeerakumar Can you tell me what problem are you facing?

Are you facing any issue with the code in PR ?

My problem : My code works fine locally but if i clone the code in my PR, I get "data referenced before the assignment" error.

If it works fine for you, then no issues.

@swapnilsparsh
Copy link
Owner

@SnehaVeerakumar Can you tell me what problem are you facing?

Are you facing any issue with the code in PR ?

My problem : My code works fine locally but if i clone the code in my PR, I get "data referenced before the assignment" error.

If it works fine for you, then no issues.

I am also facing the issue as I am not able to review your PR.

@SnehaVeerakumar
Copy link
Author

@SnehaVeerakumar Can you tell me what problem are you facing?

Are you facing any issue with the code in PR ?
My problem : My code works fine locally but if i clone the code in my PR, I get "data referenced before the assignment" error.
If it works fine for you, then no issues.

I am also facing the issue as I am not able to review your PR.

Sorry, I did not get you. Why are you not able to review the PR?
Is there anything to resolve from my side other than merge conflicts ?

@swapnilsparsh
Copy link
Owner

@SnehaVeerakumar Can you tell me what problem are you facing?

Are you facing any issue with the code in PR ?
My problem : My code works fine locally but if i clone the code in my PR, I get "data referenced before the assignment" error.
If it works fine for you, then no issues.

I am also facing the issue as I am not able to review your PR.

Sorry, I did not get you. Why are you not able to review the PR?
Is there anything to resolve from my side other than merge conflicts ?

I will try to fix the issue which I am facing while reviewing your PR, give me some time.
Thank you for being patient.

@github-actions
Copy link

Thank you @SnehaVeerakumar for your contribution. Looking forward for more such amazing contributions :)

@SnehaVeerakumar SnehaVeerakumar deleted the with-profile-edit branch May 26, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakshikhachane sakshikhachane sakshikhachane requested changes

@swapnilsparsh swapnilsparsh Awaiting requested review from swapnilsparsh

Assignees
No one assigned
Labels
changes requested gssoc21 GirlScript Summer of Code 2021
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Profile section with edit
10 participants
@SnehaVeerakumar @swapnilsparsh @khanfarhan10 @sakshikhachane @tanishq-arya @naman153 @VaibhavSharma24 @aditya201551 @AB-san @Ankita297